Not signed in (Sign In)
 
Nov 10th 2007
 
A link generated from a search page (uses Focus in the URL instead of a page number) to a comment in a multi-page discussion confuses the page list class:

http://lussumo.com/community/discussion/7358/
http://lussumo.com/community/discussion/7355/
 
Nov 14th 2007
 
Preliminary fix, will be testing it out:
// If trying to focus on a particular comment, make sure to look at the correct page
$Focus = ForceIncomingInt('Focus', 0);
$PageCount = CalculateNumberOfPages($this->CommentDataCount, $this->Context->Configuration['COMMENTS_PER_PAGE']);
if ($Focus > 0 && $PageCount > 1) {
$this->CurrentPage = 10;
$FoundComment = 0;
while ($this->CurrentPage <= $PageCount && !$FoundComment) {
$this->CurrentPage++;
$this->CommentData = $CommentManager->GetCommentList($this->Context->Configuration['COMMENTS_PER_PAGE'], $this->CurrentPage, $DiscussionID);
while ($Row = $this->Context->Database->GetRow($this->CommentData)) {
if (ForceInt($Row['CommentID'], 0) == $Focus) {
$FoundComment = 1;
break;
}
}
$this->CurrentPage++;
}
$this->Context->Database->RewindDataSet($this->CommentData);
}
 
Nov 15th 2007
 
Fixed r676.

Could not duplicate the problem that kept the focus parameter in the URL, preventing the user from paging off a focus page (http://lussumo.com/community/discussion/7355/)

Issue information

  • 33
  • WallPhone

    WallPhone

    Bug Tracker

  • Resolved
  • Low
  • Bug

Vanilla 1.1.5 is a product of Lussumo. More Information: Documentation, Community Support.