Not signed in (Sign In)

Vanilla: Ajax sortroles contains hardcoded DB calls

Bottom of Page

1 to 7 of 7

  1.  
WallPhone
 
Jan 4th 2008
 
Dinoboff
 
Jan 4th 2008
 
fixed - revision 686.

But it might be better to use the category manager and role manager (adding a new method I guess) to change priorities.
WallPhone
 
Feb 24th 2008
 
It appears the commit failed--sortroles and sortcategories still contain hardcoded table names --?
Dinoboff
 
Feb 24th 2008 edited
 
sems ok to me:
sort category:$Sql = 'update '. GetTableName('Category', $DatabaseTables, $Configuration["DATABASE_TABLE_PREFIX"])
. ' set ' . $DatabaseColumns['Category']['Priority'] . " = '//1' where "
. $DatabaseColumns['Category']['CategoryID'] ." = '//2';";

and sort user:$Sql = 'update '. GetTableName('Role', $DatabaseTables, $Configuration["DATABASE_TABLE_PREFIX"])
. ' set ' . $DatabaseColumns['Role']['Priority'] . " = '//1' where "
. $DatabaseColumns['Role']['RoleID'] ." = '//2';";
WallPhone
 
Feb 24th 2008
 
That's odd... I exported a fresh copy to work with this morning and it didn't have those changes in it... and I don't see them when going direct to http://lussumo.com/svn/vanilla/trunk/src/ajax/sortcategories.php either.
Dinoboff
 
Feb 24th 2008
 
I must have doing something weird like switching the wrong folder. I will check that tomorrow.
Dinoboff
 
Jun 24th 2008
 
fixed - r711.

1 to 7 of 7

  1.  

Issue information

  • 42
  • Dinoboff

    Dinoboff

    Bug Tracker

  • Resolved
  • Low
  • Bug

Vanilla 1.1.2 is a product of Lussumo. More Information: Documentation, Community Support.