Not signed in (Sign In)
 
Feb 5th 2008 edited
 
http://lussumo.com/community/?CommentID=82494 (// Discussions Table Structure $DatabaseColumns['Discussion']['Draft'] = 'Draft'; ?> # 1)
http://lussumo.com/community/?CommentID=82076 (Unidentifiable error injecting code before <!DOCTYPE...> in header # 1)
http://lussumo.com/community/?CommentID=82063 (Attachments # 38)
http://lussumo.com/community/?CommentID=81960 (Insane Error Possibly Causing Big Problems.... HELP! # 1)
http://lussumo.com/community/?CommentID=80413 (UserAward # 2)
http://lussumo.com/community/?CommentID=83960 (Error while integrate mootool extension # 1)

Related to the recent change to AddConfigurationSetting?
Probably probably not, ConfigurationManager hasn't changed since 1.1.2
From this: http://lussumo.com/community/discussion/6828/fixes-for-frameworkclassconfigurationmanagerphp/

Can be duplicated by installing blogThis, (?> is not put on its own line) browsing to some other page, then turning on SavedSearches which doesn't see the ?> and adds extra code to the bottom of the file.

Now that I'm having trouble duplicating this again, I'm making a list of extensions that have manifested this:
BlogThis
Attachments
Vanilla Voting
Moo Tools
UserAward
Saved Searches
Discussion Tags
 
Jun 9th 2008
 
I just looked at AppendToConfigurationFile() and it rely on the file finishing by a line only contain '?>' . It seems weak to me.

We could rewrite the class and functions that deal with appending setting files so that they first lock the file;

Then reformat the content so that it should start by <?\n and then only contains comment or single line of php code with or without comment but it should never contains ?>; A php file doesn't require to end with it.

Then append some code.

And finally unlock the file.

Issue information

  • 50
  • No assigned user

    No assigned user

     

  • Open
  • Medium
  • Bug

Vanilla 1.1.2 is a product of Lussumo. More Information: Documentation, Community Support.