I was ploughing through code and data when I came upon an oddity in the whisper tracking tables. The lum_DiscussionUserWhisperTo contains columns WhisperToUserID, keeping track of whispers recieved by a user in a discussion, and LastUserID, the last user to send such a whisper. In this the data is normal, and can be confirmed by the code:$s->AddFieldNameValue('WhisperToUserID', $Comment->WhisperUserID);
$s->AddFieldNameValue('LastUserID', $this->Context->Session->UserID);However, here is where we find what looks like a bug. The lum_DiscussionUserWhisperFrom table has similar columns -- WhisperFromUserID and LastUserID -- performing much the same function as the other table's, but in reverse: the former records whispers sent from a user in a discussion, and the latter /should/ track the last user to recieve one of these. However, the code for that section does not follow this goal:$s->AddFieldNameValue('WhisperFromUserID', $this->Context->Session->UserID);
$s->AddFieldNameValue('LastUserID', $this->Context->Session->UserID);It looks suspiciously like mark forgot to change a paramater while saving himself some coding...

oh yeah this is in CommentManager::SaveComment, btw

Welcome to what is probably the most confusing function in Vanilla. I've written and rewritten this function more times than I care to count. Have you seen the bug rear it's head somewhere? Can you cause the bug to happen?