If you're using the latest Vanilla revision, and wondering why the Quotations extension wasn't working, well I fixed it. The changes to the XHTML templates were messing up the javascript, causing it to return blanks. All has been rectified.

Also I updated the stylesheet to reflect the new layout, and to be a little more "Vanilla-like".

Get it here

Screenshot:

Whoops. Fixed.

Oooh, partial selection would be cool.

Hmm, document.getSelection() only returns text, though.

you might also try messing with a mysterious property called anchorOffset - i can't find much documentation about it, but it supposedly marks the start of the selection as related to the beginning of the text in the node.

Any working versions of the Quotations extension for a very recent 0.9.3?

The version linked above was tested with revision #358, and seems to work fine. (certainly better than it worked before)

well, almost perfectly. it catches everything except the outermost tag.
for example if i select all of this: ddddddsss

it returns ddd<u>ddd</u>sss, so it's missing the <em> tags.

but i think i can make it work.

hmm... doesn't work for me in firefox 1.5.0.2

oh, i think i see. you need to use onmousedown instead of onclick for the quote link.

but there is another problem.
no matter where i click quote on the page, it always cites the author of the last comment on the page. i had that problem for a while and i ended up having to re-analyze the dom tree and get all the elements by a different method.

my code is here but it looks nothing like yours :)
also i haven't added the new appendChild business yet.

Yup works perfect, (by works perfect I mean I barely tested it but it does now get the new quote).

You can try it out over at this board

And that right there is the exact reason I won't be bothering to install any quote feature on my site :P

Still a very nice extension, good work Bergamot!

Looking good, Bergamot. Do you have any plans of adding language definitions to it?

i had that problem too. if you go into Quotations/default.php and change

Extension Url:
to
Extension Url: null

it will show up in the extensions list.

And that right there is the exact reason I won't be bothering to install any quote feature on my site :P

Don't let that deter you, the extension is used quite properly outside of that thread. They were just loving the brand new quote feature, in the appropriate discussion too I might add. They celebrated by going nuts with the quoting!

Is there a way of testing for the existence of other extensions?

Bergamot, as you wrote, if I change the variables at the top of quote.js as follows it will work with textile too:

var tagOpenQuote = "bq. ";
var tagOpenCite = "??";
var tagCloseQuote = "";
var tagCloseCite = "??";


but the TextileFormatter wraps an extra set of p-tags around all of "commentText" resulting in invalid code. It's easy enough to take out of the relevant textile function to get it working, but it would be better if it did that "when the quotations extensions is active". How would I go about testing for that in the following php function:


if ($tag == "bq") {
$cite = $this->checkRefs($cite);
$cite = ($cite != '') ? ' cite="' . $cite . '"' : '';
// $start = "\t<blockquote$cite>\n\t\t<p";
$start = "\t<blockquote$cite>\n\t\t"; // replacement without opening-p-tag
// $end = "</p>\n\t</blockquote>";
$end = "\n\t</blockquote>"; // replacement without closing-p-tag
}

// return "$start$atts>$content$end";
return "$start$atts$content$end"; // replacement without closing-angle-bracket



As you can see, the "// commented out" lines are the original code. Possibly it would be better to have an entirely separate replacement textile-bq-function-when-quotes-extension-active to make it easier to manage updating.

Alternatively, would it be better to test around the other way, i.e. from the quotation extension to test if textileformatter or markdownformatter is active? I guess it depends upon the order in which they're processed.

BTW: Bergamot, I like the ability to highlight just a portion of the text and then click "quote". Neat.

uzi: did you get it to work. I'm having the same problem in the pre-release version of vanilla

do you have the html formatter extension turned on?

Yeah, if you want it to do bbcode, you have to edit the javascript file.

Eventually I'd like to assemble scripts for each different markup language.

It will work fine with BBCode once someone modifies the javascript to output BBCode instead of HTML. The code was designed so this would be pretty easy to do.

Until then, it's HTML only.

i have an idea!

ban bbcode from the earth for all eternity.

Ok because I don't have time to put together packages for the addin page tonight, you can get the Better BBCode Extension 1.0 here, and the BBCode javascript file for the Quotations Extension here.

Try it now :D

sweet! will give it a shot later.. will the new updated quotations work w/ both the html and bbcode at the same time?

I uploaded the new version with BBCode and language support.

Hmm, that seems like a problem with the way I'm accessing the language dictionary; I'll have to look at it later.

EDIT: for now, replace that line with:
$CommentList .= '<a onmousedown="quote(this);">quote</a>';