Not signed in (Sign In)

Categories

Vanilla 1.1.5 is a product of Lussumo. More Information: Documentation, Community Support.

Help keep Vanilla free:
Welcome Guest!
Want to take part in these discussions? If you have an account, sign in now.
If you don't have an account, apply for one now.
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 7th 2007 edited
     # 1
    An improved permalink, based on comments from this discussion:
    Req: Post # in Permalink.

    Download here:
    Comment Links
    • CommentAuthormis-one
    • CommentTimeFeb 7th 2007
     # 2
    I hate giving negative feedback off the bat, just wanted to note that it does not work with FriendlyURL's ;)
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 7th 2007 edited
     # 3
    Ouch, that is nasty.

    OK, the fix should be working now.
    •  
      CommentAuthorAres
    • CommentTimeFeb 7th 2007
     # 4
    Great extension! I had allready changed the 'old' permalink extension (the text 'permalink' to '#'), but now with the exact number next to it's even better! Thanks!
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 9th 2007
     # 5
    Thanks to a suggestion from [-Stash-], I have done some extensive updating of the extension.

    I have been so excited about this I couldn't sleep...

    Basically, the extension looks to see what formatters you have and formats the link in accordance--single click, you get a menu of installed formatting options, double click and you get it in the format you last used. Right-click and you can copy the URL just like any other.

    Only problem is that it doesn't yet work in FF, although it should work with copy just like the filebrowser does (Anybody know why???)

    A total fix for friendly URLs is now in place.
    • CommentAuthortcorbet
    • CommentTimeFeb 10th 2007
     # 6
    Strange problem. Enabling this extension causes the display of the radio buttons for "Format comments as" to be dropped from the page.
    I am running the most current code of both Vanilla and this extension. It is a solid error -- toggling enabled/disabled consistently masks or unmasks the problem.
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 10th 2007
     # 7
    I've fixed that in a development version...along with Kses integration. You need to copy the value of the StringFormatters before for-eaching throught them... for some strange reason.

    The only known bug left is the copy to clipboard one.
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 12th 2007 edited
     # 8
    Fixed the clipboard issues... it should work with any flash-enabled browser now.

    Opera has an annoying bug. Z-Index makes no difference:

    edit:Turns out this happens if you enclose a block element within a inline element... not sure how I'm going to fix this one...
    •  
      CommentAuthorWanderer
    • CommentTimeFeb 12th 2007
     # 9
    Quote: WallPhone
    picTurns out this happens if you enclose a block element within a inline element... not sure how I'm going to fix this one...pic

    You could always use a table?
    May not be elegant CSS to please the purists but from the users' perspective it will look right. pic

    Posted: Tuesday, 13 February 2007 at 10:13AM (AEDT)

    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 12th 2007 edited
     # 10
    I think I found a solution by putting the menu in the comment body, while the link that activates it remains in the span.

    BTW, how well does it look/work in Safari? http://edacio.us/forum/?CommentID=138

    Grr... positioning is now fubared in FF 1.5.
    •  
      CommentAuthorWanderer
    • CommentTimeFeb 12th 2007 edited
     # 11
    It looks great (in Safari), works too! pic

    PS: Love your "page delivered in..." script! pic

    Posted: Tuesday, 13 February 2007 at 11:50AM (AEDT)

    •  
      CommentAuthor[-Stash-]
    • CommentTimeFeb 13th 2007
     # 12
    Works fine in fx2. Don't suppose you could make the menu disappear when you click someone not on it could you?
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 13th 2007
     # 13
    OK, menu now acts a little more like an normal menu.

    Last thing is the redirection to a login form when a valid session is required...
    •  
      CommentAuthorjeremy2
    • CommentTimeFeb 13th 2007
     # 14
    Quote: WallPhone
    picTurns out this happens if you enclose a block element within a inline element... not sure how I'm going to fix this one...pic


    Actually, the reason for this is that is this is illegal. You better be careful or I'm going to sic the 3WC police on you.... Of course, they discourage you from turning inline elements into blocks, such as in:

    a.blocked {
    display: block;
    }

    but I break that one all the time. It helps to do CSS rollovers with attributes like widths and margins since the older browsers that suck (*cough* IE6 *cough) do not support :hover on anything other than anchors. For the record, I think IE7 sucks, too - just not nearly as much as IE6.
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 14th 2007
     # 15
    I completely agree with you, infact, when Opera started barfing I went to the W3 validator myself and found out it was illegal. Interesting that the fact positioning an element absolutely, which technically 'completely removes it from the normal flow of the page' does not give you licence to violate the 'inlines cannot contain blocks' rule. You can't block your spans either to get around this, since it is enforced completely independant of styles.

    Its all OK now, except for the fact that I am blocking my a's...(shhh, don't tell :-) they make much friendlier menus with more logical clickable areas. I suppose a lot of padding with a hidden overflow would replicate... but I think a little rebellion here doesn't hurt.
    •  
      CommentAuthor[-Stash-]
    • CommentTimeFeb 14th 2007
     # 16
    Is the extension updated? I'd like to give this new one a go :)
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 14th 2007
     # 17
    Sure is. Will probably sit it at 0.9.5 for a week or two.
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 16th 2007 edited
     # 18
    I was able to finish everything I wanted to with this extension... so its now officially version 1.0!

    EDIT: Somehow, I forgot to include the _clipboard.swf file in the download. If the clipboard functions don't work... that file needs to be in the CommentLinks folder. Fixed in add-ons.
    •  
      CommentAuthor[-Stash-]
    • CommentTimeFeb 18th 2007
     # 19
    Look forward to checking this out later today :) Nice work WallPhone :)
    •  
      CommentAuthorØ
    • CommentTimeFeb 23rd 2007
     # 20
    I didn't make the change yet on my main forum... But I noticed this extension's URL are different from Permalink's URL. It has really nice features, but my question is: if I install this instead of the old Permalinks extension, where will my old links point to? I mean, I'd really love to use this, but what about old bookmarked comments?
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 23rd 2007
     # 21
    The old permalinks point to an already existing anchor, so they should still work. I will double check on that.

    However, I have slightly changed the way they are linked if you have Friendly URLs installed so that they will continue to work if friendly URLs is later turned off. This last update is pending a round of tests, and should be released tomorrow.

    This update fixes an incompatibility with Comment Protection and makes pages that are much more lightweight, since the menu is generated entirely with Javascript, rather than embedding the menu in every comment and the script just showing or hiding it. There will also be a theme file packaged with it that allows you to copy a comment's URL directly from the comment search results page.
    •  
      CommentAuthorØ
    • CommentTimeFeb 24th 2007
     # 22
    Thanks for these details, I'm looking forward to the next release :)
    •  
      CommentAuthorsquirrel
    • CommentTimeFeb 27th 2007 edited
     # 23
    Strangely, it works fine in Safari but does not work in Firefox 2.0.0.2 on Mac OS X 10.4.8.

    That is to say, the menu works but nothing gets copied to the clipboard.

    edit: ahh, that would be because Firefox disallows clipboard access by scripts...
    •  
      CommentAuthorWanderer
    • CommentTimeFeb 27th 2007 edited
     # 24
    I'm running Firefox 2.0.0.1 and it works well on my forum, is this a new development in Firefox 2.0.0.2?
    It does not work at all here on Lussumo because the extension (broken version) has still not been updated.

    Posted: Tuesday, 27 February 2007 at 5:42PM (AEDT)


    Later...
    OK I updated to Firefox 2.0.0.2 and Comment Links v1.3.1 still works perfectly.

    Posted: Tuesday, 27 February 2007 at 5:50PM (AEDT)

    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 27th 2007
     # 25
    Although, it should work.

    I have personally tested with Opera 8.5, 9, IE 6, 7, FF 1.5 and 2 on Windows XP, as well as FF 2 and Konqueror on Ubuntu 6.10.

    Both IE 7 (with a nag dialog) and FF (allowed with a buried preference) are supposed to prevent clipboard access with Javascript. But there is a loophole if you pass that information through Flash.

    If your Firefox has flash installed, it should copy.
    •  
      CommentAuthorsquirrel
    • CommentTimeFeb 27th 2007
     # 26
    Ahhh, I do have Flash but I also have Flashblock. This is probably an unfixable problem for me, unless we can get a law passed mandating the death penalty for serving pop-up Flash adverts.

    Is there an option in this extension for the "dumb way" that ditches the menu and simply gives each comment a permalink to itself? That way I could just right-click and select "Copy Link Location".
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 27th 2007
     # 27
    Yah, you can do that with the gray link that normally pops the menu--works for those without Javascript too :-)

    As far as flashblock, it looks like it leaves a placeholder if you want to allow a flash to run... I could try putting it in a visible area, like right under the menu instead of a hidden div offpage... would that at least let you allow it to run in flashblock?
    •  
      CommentAuthorsquirrel
    • CommentTimeFeb 27th 2007
     # 28
    Yah, you can do that with the gray link that normally pops the menu

    Well... yeah! If I wanted to be obvious about it! Pshh! [runs away] [hides]

    Honestly I wouldn't bother trying to hack around Flashblock. I don't think it's common enough to justify adding more complexity to the extension, especially when relief is just a right-click away.
    •  
      CommentAuthorAndy K
    • CommentTimeMar 10th 2007
     # 29
    Hey all, I'm noticing the same problem that tcorbet noticed above. Baiscally, I've got the latest Vanilla (1.1.1), and the latest Comment Links (1.3.1), and when I enable Comment Links I notice that immediately all the radio buttons like "Text", "HTML", BBCode" etc disappear after "Format comments as". If I re-edit a post I already made, they appear, but they cannot be seen in new posts.

    Is there a fix for this yet? Thanks!
    -Andy
    •  
      CommentAuthor[-Stash-]
    • CommentTimeMar 10th 2007
     # 30
    Andy K, I've just noticed that I have the same problem on my test forum as well. I only get the formatter options on a post edit or a new discussion.
    •  
      CommentAuthorWallPhone
    • CommentTimeMar 10th 2007
     # 31
    That bug was supposed to be squashed in beta. It seems iterating through the installed formatters moved the array cursor and then Vanilla started to read the array from its end instead of the beginning.

    Apparently some versions of PHP handle my workaround differently. You should be able to fix this by inserting reset($Formatters); on line 45 (right after the foreach loop).
    •  
      CommentAuthor[-Stash-]
    • CommentTimeMar 12th 2007
     # 32
    I can confirm this does the trick, thanks WallPhone :) Will you update this in the extension download?
    •  
      CommentAuthorWallPhone
    • CommentTimeMar 12th 2007
     # 33
    this is a hack that fixes symptoms caused by a hack... so the next update simply removes the first hack.

    I am working on getting this to work with Userinfo Tooltip, and will post an update when that is done.
    •  
      CommentAuthorBassetts
    • CommentTimeMar 14th 2007
     # 34
    I still have no "Format comments as" radio buttons when using this extension. I have tried the fix you suggested also.
    •  
      CommentAuthorWallPhone
    • CommentTimeMar 14th 2007
     # 35
    OK, I uploaded a new version that should fix the disappearing options. There is also an attempted fix for a Safari bug that keeps the menu from appearing a second time once it has been opened and closed.

    This doesn't fix the JQ Thickbox or Userinfo Tooltip conflicts that I am still researching.
    •  
      CommentAuthorBassetts
    • CommentTimeMar 14th 2007
     # 36
    I have tried the new version and the "Format comments as" radio buttons now show but when I click the link to display the menu it just gets stuck saying "Loading"
    •  
      CommentAuthorWallPhone
    • CommentTimeMar 14th 2007
     # 37
    Grrr...

    What version of PHP?
    •  
      CommentAuthorBassetts
    • CommentTimeMar 14th 2007
     # 38
    It is running 5.2.1. It is not my public server just a development one but I guess other people could be running a similar setup.
    •  
      CommentAuthorWallPhone
    • CommentTimeMar 14th 2007
     # 39
    I forgot some quotes, workes now.
    •  
      CommentAuthorBassetts
    • CommentTimeMar 14th 2007
     # 40
    I shall upload it in a few minutes and let you know how it goes. I keep forgetting what I am doing let alone a few quotes, long day :-(
    •  
      CommentAuthorBassetts
    • CommentTimeMar 14th 2007
     # 41
    Working fine now. Thank you very much.
    •  
      CommentAuthorWanderer
    • CommentTimeMar 15th 2007
     # 42
    Quote: WallPhone
    pic There is also an attempted fix for a Safari bug that keeps the menu from appearing a second time once it has been opened and closed. pic

    Nope, sorry mate, issue still persists! pic

    Posted: Thursday, 15 March 2007 at 4:45PM (AEDT)

    • CommentAuthorRusCom
    • CommentTimeFeb 19th 2008
     # 43
    hi 2 all.I have a question. In what coding the name of a theme is copied? My database coding is cp-1251, but the name of the reference is displayed incorrectly. How it is possible to correct it?
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 19th 2008
     # 44
    • CommentAuthorRusCom
    • CommentTimeFeb 20th 2008
     # 45
    Thanks, I have read through. Today has created base with the utf charset and instal new vanilla forum, but the problem has remained. When Comment Links is copied discussion title, distinguishes half of letters, for example, the discussion title: тема первая, кодировка утф
    but the link is
    ....?CommentID=3 (�FFDема пе�FFDва�FFD, коди�FFDовка �FFD�FFD�FFD # 3

    Other extentions, such as Preview post works great with this charset
    •  
      CommentAuthorWallPhone
    • CommentTimeFeb 21st 2008
     # 46
    Oh I see... My guess this is caused by encoding the name in PHP, but its decoded by Javascript. I'll see what can be done to fix that.
Add your comments
    Username Password
  • Format comments as