Not signed in (Sign In)

Categories

Vanilla 1.1.5 is a product of Lussumo. More Information: Documentation, Community Support.

Help keep Vanilla free:
Welcome Guest!
Want to take part in these discussions? If you have an account, sign in now.
If you don't have an account, apply for one now.
    • CommentAuthordavidk43
    • CommentTimeMar 30th 2007 edited
     # 1
    A shared location mark-up map page/tab for members to tag. Non-members can view markers and comments on the map, but only members can add and edit. I saw it as a genuinely good use of maps if the forum is localised.

    Note: If someone would like to improve my database layer (and procedural code) and help tighten this up in general, it would be greatly appreciated!
    •  
      CommentAuthorGMonkey
    • CommentTimeMar 30th 2007
     # 2
    I get this error;
    Notice: Undefined variable: row in
    gliving.tv/html/community/extensions/GoogleMapDirectory/default.php on line 130

    When trying to add a new location
    • CommentAuthordavidk43
    • CommentTimeMar 31st 2007
     # 3
    Darn it, I was sure I'd tested it thoroughly. What browser are you using, I'll try and replicate the error and revise...
    •  
      CommentAuthorGMonkey
    • CommentTimeMar 31st 2007 edited
     # 4
    I am using Camino on the Mac and Firefox 2 on the mac. I will turn the map back on and you can see it on our site, http://gliving.tv/community/extension.php?PostBackAction=GoogleMapDirectory
  1.  # 5
    Uploaded version 0.2 of GoogleMapDirectory.
  2.  # 6
    Uploaded version 0.2 of GoogleMapDirectory.
    • CommentAuthordavidk43
    • CommentTimeMar 31st 2007 edited
     # 7
    Hi GMonkey,

    Give this 0.2 version a go. A few revisions noted in the default.php. Let me know what happens. Cheers for your patience on this, its my first extention so bound to be a few teething problems. This is working fine on Firefox and Explorer on PC (some noddy error exceptions on IE, though they don't affect functionality), I don't have your browser so I'll use you as my tester if you don't mind!
    •  
      CommentAuthorGMonkey
    • CommentTimeMar 31st 2007
     # 8
    I have updated to version 0.2 and now the error is gone, but once you add the second loaction, all locations are not visible. The location ballons and links below the map are missing. The data is in the database, just doesn't show on the site.

    A few request, if they are not already part of this extension.

    Mulitple Pages ( 50 or so per page )
    Search
    Categories listed to jump quickly to that section
    Rating
    Reviews
    • CommentAuthordavidk43
    • CommentTimeApr 1st 2007 edited
     # 9
    OK, is this happening on both Camino and Firefox? I'm just not getting these errors, is there anything in Firefox's error console i can work from? Also ensure you've refreshed your cache and not loading previous javascript etc by mistake. If the locations aren't showing up, it should spit something out about javascript/ajax errors. I'm gonna hook up a mac next week to start testing more.

    As for the requests, no none of those are in the extension at present, and before they are entertained, I'm hoping to find another extension coder to shore up the database stuff and get the foundations solid first. I've started this at a super low version of 0.1 - 0.2 so it can develop a lot before hitting a version 1.
    •  
      CommentAuthorGMonkey
    • CommentTimeApr 1st 2007 edited
     # 10
    I have checked all Mac based browsers and nothing shows up. I have the map on if you would like to try it. http://gliving.tv/community/extension.php?PostBackAction=GoogleMapDirectory

    The data is written to the databse but nothing shows up on the page or map. Also, I do not get any error warnings now, the locations simple don't show up. You can click on the map and add the data.
    • CommentAuthordavidk43
    • CommentTimeApr 2nd 2007
     # 11
    Gmonkey, I think its breaking down due to certain data input. I'll revise the code trying to use Vanilla in built data input functions. Could you post the sql for your table at present so I can get it working with that as my test.
  3.  # 12
    Uploaded version 0.2.1 of GoogleMapDirectory.
    • CommentAuthordavidk43
    • CommentTimeApr 3rd 2007
     # 13
    Ok, found a bug in my JSON not escaping double quotes. Hopefully that'll catch your errors GMonkey. I have a feeling that's not the last I'll hear of string literal errors, but not being a guru I learn by what happens in the field...
    •  
      CommentAuthorDinoboff
    • CommentTimeApr 4th 2007
     # 14
    line 73 of default 73, replace:$Head->AddScript("http://maps.google.com/maps?file=api&v=2.69&key=".$Context->Configuration['GOOGLEMAPDIRECTORY_KEY']);
    by $Head->AddScript("http://maps.google.com/maps?file=api&v=2.69&key=".$Context->Configuration['GOOGLEMAPDIRECTORY_KEY'], '');
    Without the second argument, Addscript should add $Configuration['WEB_ROOT'] before ttp://maps.google.com/maps?...
    •  
      CommentAuthorThaRiddla
    • CommentTimeApr 4th 2007
     # 15
    Am I not doing something correctly? I am unable to get this to work at all...nothing shows up after installing the extension and inserting my API key obtained from google. Are there additional steps?

    Does anyone have a functioning example that i can view?
    •  
      CommentAuthorGMonkey
    • CommentTimeApr 6th 2007
     # 16
    Okay it works, but it is very easy to break. If a person adds a lot of information with a few paragraphs in the text area, everything stops showing up.

    I added this amount of information:

    Euphoria Loves RAWvolution is LA's hippest cafe and retail store providing all you need to begin and thrive on raw, living foods.Euphoria Loves RAWvolution is LA's hippest cafe and retail store providing all you need to begin and thrive on raw, living foods.

    Euphoria Loves RAWvolution is LA's hippest cafe and retail store providing all you need to begin and thrive on raw, living foods.

    And it broke. So either they should be allowed to add more data, or prevent them from adding too much text. Also, there should be an address text box, so they can give the address of the location.

    This is will be great once it works...
    • CommentAuthordavidk43
    • CommentTimeApr 6th 2007 edited
     # 17
    Cheers Dinoboff, I'm not great at the whole Vanilla coding thing, as you can tell by the shakey start to this, but the reason I put this up was exactly for bug finding and other coders to help me tidy it up. I had no other way of furthering it.

    I've put a basic example up at http://www.dkltd.net/vanilla

    GMonkey, keep the faith - we will get it going eventually. I too think it'll be a great plugin, but I'm in dire need of the vanilla community's more technical guys help on this. Hopefully it'll gather some momentum and get much more robust. Until then you'll have to put up with me fixing things as they break. Anyone out there got some light to shed on data integrity, vanilla and JSON...? It's giving me headaches.

    i'll add Dinoboff's code and an address box, and get that input above working - it's the paragraph line return that's crashing it. Very strange, but i'll fix it over the weekend. Also it needs a delete action, should I limit this to administrators you think?
    •  
      CommentAuthorThaRiddla
    • CommentTimeApr 6th 2007
     # 18
    Well, it appears that my map is there, but the tab in the navigation is not showing up for me. any ideas on where I might start looking to fix this? Would this have anything to do with it? Sorry, i'm not the best coder.
    /*** Add the GoogleMapDirectory Tab ***/
    if(isset($Menu)) {
    $Menu->AddTab($Context->Configuration['GOOGLEMAPDIRECTORY_TABNAME'], 'GoogleMapDirectory', GetUrl($Configuration, 'extension.php', '', '', '', '', 'PostBackAction=GoogleMapDirectory'), '',$Context->Configuration['TAB_POSITION_GOOGLEMAPDIRECTORY']);
    }

    • CommentAuthordavidk43
    • CommentTimeApr 6th 2007 edited
     # 19
    ThaRiddla, do you have any tab management/page management extensions running? I know the Page Management extension screws with the default manner of adding tabs, but if you are using that, you can simply add a tab and give the url of

    <YourDomain>/extension.php?PostBackAction=GoogleMapDirectory
    •  
      CommentAuthorSpot
    • CommentTimeApr 6th 2007
     # 20
    I've tried every which way with the directories, but just get the javascript message:

    "The Google Maps API key used on this web site was registered for a different web site. You can generate a new key for this web site at http://www.google.com/apis/maps/."

    Anybody else encountered this?
    •  
      CommentAuthorThaRiddla
    • CommentTimeApr 6th 2007
     # 21
    ThaRiddla, do you have any tab management/page management extensions running?


    That was it. Thanks! I didn't need my domain, BTW....just extension.php?PostBackAction=GoogleMapDirectory
    • CommentAuthordavidk43
    • CommentTimeApr 7th 2007 edited
     # 22
    Spot, you need to generate your own API key for your own domain, its free and instantaneous. The link to google's api key generator is on the readme file that comes with the extension.

    Also, GMonkey, I've now fixed the data integrity using base64 encoding. I've got a few more tweaks to add then i'll get a new version up. Hopefully I'll get some time over the weekend.
    •  
      CommentAuthorGMonkey
    • CommentTimeApr 7th 2007 edited
     # 23
    Davidk43

    Cool I look forward to the new one. Seems to break also if you add more than 5 location options and or use 2 or more words to describe the locations. Example: Organic Grocer, Fine Dinning, so on, breaks the map once you post 2 locations.

    Have you seen the maps with special icons for each location type?
    http://www.giveittomeraw.com/la/
  4.  # 24
    Uploaded version 0.3 of GoogleMapDirectory.
    • CommentAuthordavidk43
    • CommentTimeApr 7th 2007 edited
     # 25
    OK version 0.3 now. I've added address and telephone numbers, with a little formatting to the popups on the map. Also location creators can now delete their own markers - though the last person to edit becomes the creator - I'll change this, its an interim solution, as I'm not sure of the best place for deletes and at what level they should be. It's a little unclear as should someone be able to delete what someone else has edited? Perhaps just have admin only delete's? Or is that something admins can't be bothered with? Any thoughts on this, anyone?

    I've also added Dinoboff's ammendment and tidied up the table and some naming stuff.

    Most importantly of all i've encoded all input fields with base64 now which should address the problems above. Probably shouldn't have released this without that but I didn't have much knowledge of it before I started looking into these problems. Obviously I'm not foolish enough to declare this issue fixed just yet!

    GMonkey, yes i've played with putting different icons onto maps but think it'd be too awkward in this instance, its not just a case of letting users pin a gif/png to a category type, as they need to declare the pin point of an image etc, it gets messy quickly and you'd end up with markers not correctly place on a map if not done correctly. We could perhaps have a standard, say a marker as now with topical images overlayed, not affecting the dimensions and pinpoint of the marker, possibly something for the future but I think it'd muddy things right now.

    i had some problems with uploading this over the previous version, I ended up manually deleting the old table in the database first. Perhaps someone out there could look at that side of housekeeping for me..?
    •  
      CommentAuthorGMonkey
    • CommentTimeApr 11th 2007
     # 26
    Davidk43,

    Okay we have the map up and it is working great. People have started adding new locations. The only issue maybe how long of an entry they add. Maybe the text ballon could expand sideways a little? You can check it out here: http://gliving.tv/community/extension.php?PostBackAction=GoogleMapDirectory
    • CommentAuthoralecglen
    • CommentTimeApr 12th 2007
     # 27
    Works great for me, been up a few days and 20 locations added already with no problems although nobody's tried putting much in the text balloon as its not needed yet. Different icons might be nice even just different coloured markers could be quite handy but no point giving yourself too much work just yet!
    • CommentAuthordavidk43
    • CommentTimeApr 12th 2007
     # 28
    Yep, I'll add a settings variable for width of balloon in next revision, though I would say that's kind of why a had a Discussion Thread url, so you could write a short sharp description then link out to a vanilla thread for more info and chat.
    •  
      CommentAuthorGMonkey
    • CommentTimeApr 12th 2007
     # 29
    Davidk43,

    Hmm the thread idea is good, but I don't think that is clear. Maybe there there should be a text box above the links, so we can have some text explaining how to use the map..
    •  
      CommentAuthorThaRiddla
    • CommentTimeApr 12th 2007
     # 30
    Also, when you click on the "Add Location" the map goes to your default location, instead of where you are....so if you've already found somewhere to place a location you have to find it again. if that can be a variable as well, it would be great.
    • CommentAuthorgpreston
    • CommentTimeApr 12th 2007
     # 31
    • CommentAuthoralecglen
    • CommentTimeApr 13th 2007
     # 32
    Ok, when I look at it in IE and zoom out it takes the locations with them as in my house could be on the isle of man with 2 clicks. It works fine in FF but it does this in IE, does anyone else have the same problem or know of a fix?
    • CommentAuthorradioboy
    • CommentTimeApr 14th 2007
     # 33
    very nice, i just added it to www.cinemaworkshop.com/vanilla, which is our university filmmaking club

    my only qualm is that there's no search box, which would be much better than having to drag around the map
    •  
      CommentAuthorskube
    • CommentTimeApr 16th 2007
     # 34
    Shouldn't it automatically add your marker when you enter your address?
  5.  # 35
    everything works fine EXCEPT the google navigation button images are not loading for me. (ie the zoom in/out. they are just blank white squares)

    also seems to have trouble parsing punctuation like ' or "
  6.  # 36
    further, as an admin i would like to be able to delete listings. i run a san francisco based forum and someone added a map point in LA to be funny.
    • CommentAuthordavidk43
    • CommentTimeApr 18th 2007 edited
     # 37
    Hi all,

    Ok this does seem to be generating some interest now. I've been busy knocking walls down in my house and not very web2 at all! I'll try and aggregate the above as some kind of action list, which won't happen til late next week at the best.

    1) ThaRiddla - I'll try and capture the current location and pass it to the AddLocation page.
    2) alecglen - Yep, can see that glitch, i'll endeavour to fix
    3) GMonkey - I'll add an explanation and perhaps prefix that field with the discussion thread url so you just enter a discussion id number?
    4) radioboy - search has already been requested, not sure how that fits with the layout and stuff. I think we focus on getting the fundamentals working properly before extending.
    5) skube - no, the address is manual, further info for your marker
    6) onetwentyeight - the google nav comes straight out of google's code, its nothing to do with the extension, check on a few browsers. I have added a delete function but its a bit half-arsed. Next version will have 'created by' and 'last edited by' for each marker. Then admin can set whether anyone, creator or just admin can delete - at least that's the plan. I thought I'd caught the parsing issues, which field isn't working for you?

    Phew. Looks like I have my work cut out. Still no volunteers out there to help me further this?
  7.  # 38
    david - ' and " get turned into /
    • CommentAuthordavidk43
    • CommentTimeApr 18th 2007
     # 39
    128 - are you sure you've got the latest version? This is quite clearly working for me. Anyone else? GMonkey?
  8.  # 40
    yea, .3... my forum members love this extension, btw.

    ive been having a lot of bugs since i upgraded to 1.1.2, im looking into it.
    • CommentAuthorDavidK
    • CommentTimeApr 18th 2007
     # 41
    Hmm... I like 128's idea of restricting where pins can be placed.

    I might add a boxed area to the extension so that only points that fall within specific longitudes and latitudes get added. If I do this, would you like a copy of my modifications to consider adding as an option to the extension?

    It will be a boxed area, a simple "lat between a and b" and "long between x and y" thing. Test in JavaScript refuse to add if outside the boxed area, the value for a, b, x and y would be hard-coded along with a boolean switch to activate the logic within the hacks default.php file.

    V. nice hack :)
    •  
      CommentAuthorjimw
    • CommentTimeApr 18th 2007
     # 42
    I just set it up on my local install. I get js errors:
    sa.instance(qb(a)).Qm is not a function on line 121 of maps2.69.api.js

    I already have the MemberGoogleMap extension installed. Does it conflict with your?
    • CommentAuthordavidk43
    • CommentTimeApr 18th 2007
     # 43
    Yeah ok, so we add four exta fields to the settings page, if they're empty then no restrictions if they aren't then process a "boundaryLimits" function at form submission? I'm happy for that to be added, buro9. I'm working on version 0.4 which incorporates most of the above, should be ready in a week to two, want to get that to me for that release? How's your extension coding? I could do with some guidance, I'm winging this on some very limited knowledge!
    • CommentAuthordavidk43
    • CommentTimeApr 18th 2007
     # 44
    It might do jimw but I doubt it, I've been careful to not step on their toes naming-wise. Try disabling one or the other to see.
    •  
      CommentAuthorjimw
    • CommentTimeApr 18th 2007
     # 45
    Yep, your extension works after I deactivated the MemberGoogleMap extension.
    • CommentAuthordavidk43
    • CommentTimeApr 18th 2007 edited
     # 46
    aha. Thanks jimw, I'll take a look at that, i must be clashing with something. Seems to be which version of googlemaps is called, can't see why that'd clash, MemberGoogleMap guys, any ideas? Might be some other caching issues, I know Explorer does some crappy things, what browser are you using?
    • CommentAuthorDavidK
    • CommentTimeApr 18th 2007
     # 47
    My extension coding is limited... I donated a chunk of code for AJAX and JSON loading of Flickr images (prevents server work), but didn't know how to wrap it up.

    But now I've actually got an installation of Vanilla it's not so bad ;) Happy to help out if you need it.

    BTW, You appear to have left a polygon over part of North London. Commenting out drawArea() within Map.js (line 33) took care of it. Were you just playing with paths and shapes? Or did you have more functionality in mind?

    It's in use on http://www.londonfgss.com/ now :)
    • CommentAuthordavidk43
    • CommentTimeApr 18th 2007
     # 48
    Yeah that was for where the extension started, a Stroud Green local forum. I've been turning the function on and off while playing with VML stuff. I meant to leave it in if other people wanted to use it, but just comment out. Must have forgotten to re-uncomment the line. I'm shoddy at testing, what can I say...

    Your locations made me laugh. Being a London cyclist I know most of them. Small world...!
    • CommentAuthorLoOkHerE
    • CommentTimeApr 18th 2007
     # 49
    I can't get this to show added locations (they are in the database tho), using the latest version. It just shows a blank map. Is this a php5 thing? I'm still on 4.
    • CommentAuthordavidk43
    • CommentTimeApr 19th 2007
     # 50
    nope all fine on php4 LoOk HerE, what browser etc are you using? got a link to look at?