Not signed in (Sign In)

Categories

Vanilla 1.1.5 is a product of Lussumo. More Information: Documentation, Community Support.

Help keep Vanilla free:
Welcome Guest!
Want to take part in these discussions? If you have an account, sign in now.
If you don't have an account, apply for one now.
    • CommentAuthornpeirce
    • CommentTimeJul 24th 2007
     # 1
    Hi,

    I found the following problems with the way Vanilla 1.1.2 handles IPv6 addresses:

    • 1) The function GetRemoteIp() in Framework.Functions.php truncates IPv6 addresses to 19 characters
      The following line is causing the problem.
      [Line 513] if (strlen($sReturn) > 20) $sReturn = substr($sReturn, 0, 19);
      A suggested fix would be:
      [Line 513] if (strlen($sReturn) > 39) $sReturn = substr($sReturn, 0, 39);
      IPv6 addresses can have upto 39 characters e.g. 2001:0db8:0000:0000:0000:0000:1428:57ab

    • 2) The database table LUM_IpHistory also truncates IPv6 addresses to 30 characters.
      By using a varchar(40) for the column RemoteIP in this table as opposed to varchar(30) this problem can be fixed.

    There may be other IPv6 issues but these are the ones I've come across so far.
    Hopefully the above fixes can be included in a future release of Vanilla.
    •  
      CommentAuthorlech
    • CommentTimeJul 24th 2007
     # 2
    Bump for Mark or someone else versed in IPv6 as I have not yet seen an IPv6 address out in the wild to deal with.

    Currently Vanilla is relying on IPv4 addresses to record and match as an admin option and doesn't heavily rely on this data by default or at all. IPv6 is still a bit mind-boggling (for me anyway) with the number of ways you can treat a single address and I don't think anyone is going to rush in a patch to address this. Although it would benefit Vanilla later down the road when and where depending on a users IP might be more relevant.
    • CommentAuthorAlexL
    • CommentTimeAug 15th 2007
     # 3
    well, the fixes don't seem to be really difficult to include. so my vote goes to "fix it" :D
Add your comments
    Username Password
  • Format comments as