Not signed in (Sign In)

Categories

Vanilla 1.1.4 is a product of Lussumo. More Information: Documentation, Community Support.

Help keep Vanilla free:
Welcome Guest!
Want to take part in these discussions? If you have an account, sign in now.
If you don't have an account, apply for one now.

Fixes & Updates: Extra space in theme/head.php body tag

Bottom of Page

1 to 3 of 3

  1.  
    •  
      CommentAuthorsjeeps
    • CommentTimeSep 12th 2007
     # 1
    I just noticed that there's an extra space in the theme/head.php body tag:

    <body'.$BodyId.' '.$this->Context->BodyAttributes.'>

    <body id="DiscussionsPage" >

    Should be:

    <body'.$BodyId.''.$this->Context->BodyAttributes.'>

    <body id="DiscussionsPage">

    ?
    •  
      CommentAuthorWallPhone
    • CommentTimeSep 12th 2007 edited
     # 2
    Not quite, because if anything is set in BodyAttributes, then you get the ID and the attributes run together.

    Probably better to use this:<body'.$BodyId. ($this->Context->BodyAttributes ? ' '.$this->Context->BodyAttributes : '') .'>
    Or, for better readability, in PHP code before this line:if ($this->Context->BodyAttributes) $this->Context->BodyAttributes = ' '.Context->BodyAttributes;

    Either way, the space doesn't make it invalid XHTML.
    •  
      CommentAuthorDinoboff
    • CommentTimeSep 12th 2007 edited
     # 3
    I added to the bug tracker. I put it on hold since it doesn't break anything, but fixing it could break extension.

    http://lussumo.com/bugs/discussion/24/extra-space-in-themeheadphp-body-tag/#Item_1

1 to 3 of 3

  1.  
Add your comments
    Username Password
  • Format comments as
 
Back to Discussions Top of Page